Move header files into include/midifile folder.#63
Move header files into include/midifile folder.#63no-more-secrets wants to merge 1 commit intocraigsapp:masterfrom
Conversation
Effectively we add a folder "namespace" to the midifile headers. This is standard practice when structuring a library (e.g. note boost does this). When a parent project includes this library it will be more clear which headers belong to the `midifile` library. Also a minor CMake fix is made which will associate the header folder with the `midifile` CMake target in accordance with modern CMake best practices. These changes make the project more friendly to the common workflow of incorporating the library into a larger project as a git submodule.
|
Ping! |
|
Is this repo still being maintained? |
|
I pay attention to the repo every January/February when I teach MIDI in my class :-) You still find this useful (as a Windows user, while I am a unix/mac user)? As long as no one on the watch list complains, I will do it this week. When I use the files in an external project, I just copy them into the |
Note that when included from a C++ file it will be Anyway, if you are planning to merge this, then please let me know so that I can update the branch and resolve the merge conflicts (which I don't want to do unless you're going to merge it). Thanks |
Effectively we add a folder "namespace" to the midifile headers.
This is standard practice when structuring a library (e.g. note
boost does this). When a parent project includes this library it
will be more clear which headers belong to the
midifilelibrary.
Also a minor CMake fix is made which will associate the header
folder with the
midifileCMake target in accordance with modernCMake best practices.
These changes make the project more friendly to the common
workflow of incorporating the library into a larger project as a
git submodule.
Fixes #62