The std::vector argument to addMetaEvent should be const.#56
Open
dewhisna wants to merge 1 commit intocraigsapp:masterfrom
Open
The std::vector argument to addMetaEvent should be const.#56dewhisna wants to merge 1 commit intocraigsapp:masterfrom
dewhisna wants to merge 1 commit intocraigsapp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version of the
addMetaEventfunction that takes themetaDataas astd::vectortype should accept thatstd::vectorargument as aconsttype. Otherwise, callers of this function that pass data from constant member functions and/or retrieve their data from constant getter functions have to either do aconst_castor declare their own types mutable and/or add temporary variables of a non-const type when they shouldn't need to.