updated cmake_minimum_required VERSION to 2.8...4.0#119
Open
julian-pfaul wants to merge 2 commits intocraigsapp:masterfrom
Open
updated cmake_minimum_required VERSION to 2.8...4.0#119julian-pfaul wants to merge 2 commits intocraigsapp:masterfrom
julian-pfaul wants to merge 2 commits intocraigsapp:masterfrom
Conversation
Author
|
Additionally I just discovered, that the tools: midi2beep, henonfile, mid2hum, midiexcerpt, and peep2midi were being build dispite the BUILD_MIDILIBRARY_ONLY flag being set. I moved the endif statement of the "if(NOT BUILD_MIDILIBRARY_ONLY)" statement to include these tools. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake decided to break backwards compatibility for versions lower than 3.5 since the new version 4.x came out.
After trying to build midifile using CMake 4.0 yields a fatal error:
Since the CMakeLists.txt file is already version 4.0 compatible without any changes necessary, I updated the VERSION parameter of the cmake_minimum_required to "2.8...4.0", to reflect that, and to enable the project to be buildable again using CMake. This should effectily reenable users to build midifile using CMake.