Do not push size of the data into the SysEx#103
Open
Monceber wants to merge 1 commit intocraigsapp:masterfrom
Open
Do not push size of the data into the SysEx#103Monceber wants to merge 1 commit intocraigsapp:masterfrom
Monceber wants to merge 1 commit intocraigsapp:masterfrom
Conversation
|
Hi @craigsapp , any plan on merging this fix? At the moment, Verovio's tuning (and any sysex) feature is broken because the exported MIDI is invalid due to this bug. Thanks! |
Owner
|
Yes I should fix it soon. To summarize: (1) the size of the metamessage should be written as a Variable Length Value, or (2) for sysex message the length of the dat shoule be removed sinde there is a byte code to end the message. |
|
When I analyzed this issue, I found that |
|
Hello, is there any support I can bring to help get this fix merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've done some testing with mts-type2.cpp and adding size to the SysEx seems to break the functionality. The message is ignored and no tune changes are made.
Here is an archive with two WAV files (converted from MIDI to WAV via Timidity) and two original MIDI files. quarter_with_size has size of the data array added to the message, while quarter_without_size - does not.
quarters.zip
Additionally, if I were to compare results from #99 with the ones that I get, they seem to match with the ones, made without adding size.
Size of file from archive in this matches with the size of MIDI generated without size (368 bytes). As does MIDI generated from Ratioscore lack this one byte, representing size of the SysEx message.