Conversation
| # cur=conn.cursor() | ||
|
|
||
|
|
||
| db_config = { |
Contributor
There was a problem hiding this comment.
This credentials should be from config and config will not be pushed to git.
| def get(self): | ||
| conn = db_connection() | ||
| cursor = conn.cursor(pymysql.cursors.DictCursor) | ||
| query = "SELECT * FROM employee" |
Contributor
There was a problem hiding this comment.
NO DB calls in service file. All external call like db or external api will be via coordinator.
|
|
||
|
|
||
| # Database connection | ||
| def db_connection(): |
Contributor
There was a problem hiding this comment.
do not declare this in each service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds endpoints to manage employees and books in the application. It includes full CRUD operations
GET: Retrieve all or specific employee/book.
POST: Add a new employee/book.
PUT: Update existing employee/book.
DELETE: Remove an employee/book by ID.