Implement CRUD Endpoints for User and Book Tables#1
Open
datirsayali wants to merge 3 commits intomainfrom
Open
Implement CRUD Endpoints for User and Book Tables#1datirsayali wants to merge 3 commits intomainfrom
datirsayali wants to merge 3 commits intomainfrom
Conversation
| from app.connections import SqlConnection | ||
| class SubApp1Service: | ||
| db_config = { | ||
| 'host': 'localhost', |
Contributor
There was a problem hiding this comment.
This credentials should come from config and not in code.
|
|
||
| def get_books(self): | ||
| try: | ||
| query = "select * from books" |
Contributor
There was a problem hiding this comment.
All queries will be done in the coordinator only logic in service file.
|
I added the database query code in coordinator.py file and push changes with new commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces CRUD (Create, Read, Update, Delete) endpoints for user and book.
User Table:
Create User : Endpoint to add a new user.
Read Users : Endpoint to fetch list all users.
Update User : Endpoint to update user details by id.
Delete User : Endpoint to remove a user by id.
Book Table:
Create Book: Endpoint to add a new book.
Read Books/book : Endpoint to fetch a book by id and list all books.
Update Book: Endpoint to update book details by id.
Delete Book: Endpoint to remove a book by id.