fix: preserver utf8 charset in filenames

[alex-Arc]

allows characters like æ ø å to be used in filenames
also axios hadles the Content-Type automatically for multipart/form-data encoding

Watch for changes here expressjs/multer#1210

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-utf8-filenames

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cpvalente]

If I understand this correctly, the browser APIs are not supporting non-utf characters as first class citizens.

In that case, we shouldnt try to fight against it since we may just be pushing hard to trace problems down the road.

I would suggest we make no change

[alex-Arc]

not quite
as far as I can see the default formatting for forms is UTF-8
and for some reason busboy defaults to latin1
and the express multer dose not expose that setting so it will always use latin1

The annoying thing is that we do allow a project title to include those letters, and if we download that project it has those correct letters, but then when it is uploaded again it gets mangled

[cpvalente]

The annoying thing is that we do allow a project title to include those letters, and if we download that project it has those correct letters, but then when it is uploaded again it gets mangled

Makes sense, but the point still stands. Would we not be fighting the tooling and potentially pushing the problem further into the code?

it sounds like the best thing would to not allow projects with those characters. I am specifically thinking of non Carolinian alphabets like Chinese which could become problematic in a way we just can’t handle it

[alex-Arc]

fixed up-stream, waiting for release