-
-
Notifications
You must be signed in to change notification settings - Fork 96
Group duration context menu utils #1748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…overed in the same load operation (#1744)
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
b0befcc to
ba2ec4a
Compare
6385474 to
2e6fba9
Compare
| const group = rundown.entries[groupId]; | ||
| if (!group || !isOntimeGroup(group) || group.targetDuration === null) return; | ||
| const event = rundown.entries[eventId]; | ||
| if (!event || !isOntimeEvent(event)) return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could really use a way to show errors like this
maybe the toasters we were thinking of?
| { | ||
| type: 'item', | ||
| label: 'Match Target Group Duration', | ||
| icon: TbClockPin, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideas for icons are welcome
| { | ||
| type: 'item', | ||
| label: 'Match Group Duration', | ||
| icon: TbClockPin, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideas for icons are welcome
|
@alex-Arc, lets leave this one for later |
Adds 2 items to the context menu
for the group there is now the option to set the target duration to match the accumulated duration of the group
for events inside groups one can now make that one event expand or contract in duration so that the groups target is met