Skip to content

Conversation

@alex-Arc
Copy link
Collaborator

Adds 2 items to the context menu
for the group there is now the option to set the target duration to match the accumulated duration of the group
for events inside groups one can now make that one event expand or contract in duration so that the groups target is met

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 24, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch group-duration-utils

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@alex-Arc alex-Arc force-pushed the refactor-context-menue branch from b0befcc to ba2ec4a Compare August 26, 2025 17:12
Base automatically changed from refactor-context-menue to alpha-4 August 26, 2025 17:20
@alex-Arc alex-Arc force-pushed the group-duration-utils branch from 6385474 to 2e6fba9 Compare August 26, 2025 17:21
const group = rundown.entries[groupId];
if (!group || !isOntimeGroup(group) || group.targetDuration === null) return;
const event = rundown.entries[eventId];
if (!event || !isOntimeEvent(event)) return;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could really use a way to show errors like this
maybe the toasters we were thinking of?

{
type: 'item',
label: 'Match Target Group Duration',
icon: TbClockPin,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideas for icons are welcome

{
type: 'item',
label: 'Match Group Duration',
icon: TbClockPin,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideas for icons are welcome

@alex-Arc alex-Arc requested a review from cpvalente August 26, 2025 17:26
@alex-Arc alex-Arc changed the title Group duration utils Group duration context menu utils Aug 26, 2025
@cpvalente
Copy link
Owner

@alex-Arc, lets leave this one for later

@alex-Arc alex-Arc added the Later will be taken up later label Aug 29, 2025
Base automatically changed from alpha-4 to v4 September 3, 2025 13:50
Base automatically changed from v4 to master October 7, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Later will be taken up later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants