Skip to content

Limit the number of repeated calls made to update the _target and _fov traitlets #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pcuste1 wants to merge 2 commits into from
Closed

Limit the number of repeated calls made to update the _target and _fov traitlets #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15be0b8
jitter reduction
pcuste1 Oct 8, 2025
55734ad
update comments
pcuste1 Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions js/models/event_handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@ export default class EventHandler {
return;
}
jsTargetLock.lock();

// only update `_target` once dragging is completed
if (this.aladin.view.dragging) {
return;
}

const raDec = [position.ra, position.dec];
this.updateWCS();
// When dragging the view, north to east position angle might changes because
Expand Down Expand Up @@ -128,6 +134,13 @@ export default class EventHandler {
return;
}
jsFovLock.lock();

// only update `_fov` once zooming is compelte
const zoom = this.aladin.view.zoom;
if (zoom.isZooming && fov != zoom.finalZoom) {
return;
}

// fov MUST be cast into float in order to be sent to the model
this.updateWCS();
this.update2AxisFoV();
Expand Down