Cphang/test failures gofmt

.github/workflows/CI.yaml

@@ -0,0 +1,32 @@
+name: CI
+on:
+  push:
+    branches:
+    - master
+  pull_request:
+    branches:
+    - master
+jobs:
+  gofmt:
+    runs-on: ubuntu-latest
+    container: docker://golang:1.13
+    steps:
+    - uses: actions/checkout@v1
+    - name: run gofmt
+      run: test -z "$(gofmt -d . | tee /dev/stderr)"
+  buildifier:
+    runs-on: ubuntu-latest
+    container: docker://golang:1.13
+    steps:
+    - uses: actions/checkout@v1
+    - name: install buildifier
+      run: go get github.com/bazelbuild/buildtools/buildifier
+    - name: run buildifier
+      run: buildifier -mode=check -r .
+  build_and_test:
+    runs-on: ubuntu-latest
+    container: docker://l.gcr.io/google/bazel:2.1.0
+    steps:
+    - uses: actions/checkout@v1
+    - name: build and test
+      run: bazel test //...

BUILD.bazel

@@ -6,6 +6,7 @@ load("@com_github_bazelbuild_buildtools//buildifier:def.bzl", "buildifier")
 # gazelle:resolve proto go build/bazel/remote/execution/v2/remote_execution.proto @com_github_bazelbuild_remote_apis//build/bazel/remote/execution/v2:go_default_library
 gazelle(
     name = "gazelle",
+    foo='bar',
 )
 
 buildifier(

README.md

@@ -1,4 +1,4 @@
-# The Buildbarn storage daemon [![Build status](https://badge.buildkite.com/212ccc2e6aab9f4df6490b30390492365c5641e65a768e5a51.svg)](https://buildkite.com/buildbarn/bb-storage) [![GoDoc](https://godoc.org/github.com/buildbarn/bb-storage?status.svg)](https://godoc.org/github.com/buildbarn/bb-storage)
+# The Buildbarn storage daemon [![Build status](https://github.com/buildbarn/bb-storage/workflows/CI/badge.svg)](https://github.com/buildbarn/bb-storage/actions) [![GoDoc](https://godoc.org/github.com/buildbarn/bb-storage?status.svg)](https://godoc.org/github.com/buildbarn/bb-storage)
 
 The Buildbarn project provides an implementation of the
 [Remote Execution protocol](https://github.com/bazelbuild/remote-apis).

pkg/blobstore/cloud_blob_access.go

@@ -15,7 +15,7 @@ import (
 )
 
 type cloudBlobAccess struct {
-	bucket      *blob.Bucket
+	bucket *blob.Bucket
 	keyPrefix   string
 	storageType StorageType
 }

pkg/proto/configuration/blobstore/blobstore.proto

@@ -47,6 +47,9 @@ message BlobAccessConfiguration {
     SizeDistinguishingBlobAccessConfiguration size_distinguishing = 5;
 
     // Read objects from/write objects to a circular file on disk.
+    // TODO: CircularBlobAccess should be considered deprecated as it is
+    // prone to data corruption. LocalBlobAccess should be used instead
+    // if at all possible.
     CircularBlobAccessConfiguration circular = 6;
 
     // Read objects from/write objects to a GRPC service that