fix: avoid races during interactive drive acceptance#4720
Merged
Conversation
Contributor
Author
|
also, the next step will be this issue #4721 |
taratatach
reviewed
Apr 7, 2026
1b9683c to
74b678e
Compare
taratatach
approved these changes
Apr 8, 2026
74b678e to
3314179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happend:
alice@twake.appcreated the shared drive invitation, at that point, the recipient's Cozy URL(bob@twake.app) was not yet registered on the owner side, so the system only sent the discovery email linkbob@twake.appclicked the discovery link from the emailPUT /sharings/:idon the recipient Cozy, as soon as that request arrived, the recipient recognized the sender as trusted (linagora.com) and enqueued drive auto-accept.GET /auth/authorize/sharing?..../answer, but the browser/manual path hit a stale CouchDB revision conflict and returned a409page.Changes
SendAnsweridempotent on conflicts