Fixes a notes data-loss bug where purgeAllSteps(fileID) ignored its fileID#4712
Merged
Fixes a notes data-loss bug where purgeAllSteps(fileID) ignored its fileID#4712
Conversation
shepilov
changed the title
shepilov
force-pushed
the
fix/notes_step_was_removed
branch
from
b687e27 to
b0f57ce
Compare
taratatach
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a notes data-loss bug where purgeAllSteps(fileID) ignored its fileID argument and deleted step documents for all notes in io.cozy.notes.steps, not only the targeted note.
Bug story
We investigated a production incident where a user lost note content after a reload.
This means that an action on note B could wipe unsaved steps for note A.
The most likely production trigger is: overwrite/import of another existing .cozy-note file