Skip to content

fix: adjust store icon 🐛 #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lethemanh wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix: adjust store icon 🐛 #1047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Common/ImportDropdown.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ import React, { useState, useRef } from 'react'
import { useNavigate } from 'react-router-dom'

import { useClient } from 'cozy-client'
import AppIcon from 'cozy-ui/transpiled/react/AppIcon'
import AppLinker from 'cozy-ui/transpiled/react/AppLinker'
import Button from 'cozy-ui/transpiled/react/Buttons'
import Icon from 'cozy-ui/transpiled/react/Icon'
import BottomIcon from 'cozy-ui/transpiled/react/Icons/Bottom'
import StoreIcon from 'cozy-ui/transpiled/react/Icons/Store'
import TeamIcon from 'cozy-ui/transpiled/react/Icons/Team'
import Link from 'cozy-ui/transpiled/react/Link'
import ActionMenu, {
Expand Down Expand Up @@ -50,7 +50,7 @@ const ImportDropdown = () => {
<AppLinker app={{ slug: 'store' }} href={getFilteredStoreUrl(client)}>
{({ onClick, href }) => (
<ActionMenuItem
left={<AppIcon app="store" className="u-h-1 u-w-1" />}
left={<Icon icon={StoreIcon} className="u-h-1 u-w-1" />}
Copy link
Copy Markdown
Member

@zatteo zatteo Jul 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JF-Cozy does <AppIcon/> mean that it is loading icon from "store" app but in stable release?

Copy link
Copy Markdown
Contributor

@JF-Cozy JF-Cozy Jul 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/cozy/cozy-ui/blob/master/react/AppIcon/index.jsx#L53 then https://github.com/cozy/cozy-client/blob/master/packages/cozy-stack-client/src/getIconURL.js#L144 so from stack (by default) or registry.

So I think we have to dig in these directions and not changing anything here

Copy link
Copy Markdown
Member

@zatteo zatteo Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok right, so it should be automatically fixed when updating store to stable release. I suggest we keep this PR until monday if we need it.

onClick={onClick}
>
<Link
Expand Down
Loading