Ozdasc/bump open exr34 #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Turn off failing stuff Signed-off-by: Doug Walker <doug.walker@autodesk.com> * Turn off ociolutimage Signed-off-by: Doug Walker <doug.walker@autodesk.com> * Uninstall the runner EXR Signed-off-by: Doug Walker <doug.walker@autodesk.com> * Bump EXR min version to 3.1.6 Signed-off-by: Doug Walker <doug.walker@autodesk.com> * Bump EXR recommended version to 3.1.6 Signed-off-by: Doug Walker <doug.walker@autodesk.com> * Minor clean up Signed-off-by: Doug Walker <doug.walker@autodesk.com> --------- Signed-off-by: Doug Walker <doug.walker@autodesk.com>
…& icc_profile_name (AcademySoftwareFoundation#2165) * Adding 3 new attributes to the color space: interop_id, amf_transform_ids and icc_profile_name - Addressing the issues AcademySoftwareFoundation#1975, AcademySoftwareFoundation#2152 and AcademySoftwareFoundation#2153 - Bumped the config version to 2.5 - newly added attributes require v2.5 config both for serialization and de-serialization and will throw if they appear in older configs. - Hardened multiple existing functions against null parameters. Previously those functions were crashing if null is passed, as assigning null to std::string is undefined behavior. - Expanded tests to some affected functions' unit tests to include null passing. Setters will take null as empty string. compare functions will throw. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * As discussed in the TSC meeting, adding a namespace field separator logic to the interop_id field. - only zero or one ":" is allowed in the interop_id name - ":" can not be the last character - added cpp and python unit tests. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * Adding interop_id verification in ociocheck. Non-namespaced IDs are checked against the known CIF values and warning is issued if not found. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * minor touches. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * fix the failing test. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * Disallow non-ASCII characters (outside of [0..127] range) in the interopID field. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * Fixing the tests which were failing due to exception wording change. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * - replacing getAMFTransformIDs and getICCProfileName with more generic getInterchangeAttribute function. Same with the setters - getInterchangeAttribute() and setInterchangeAttribute() functions currently knows and accepts "amf_transform_ids" and "icc_profile_name" keys. other keys will throw. - ColorSpace serializer will list all of the key/value pairs. - InteropID and interchangeAttributes are now allowed in earlier config versions down to 2.0 too. Config::checkVersionConsistency() will throw only for version smaller than 2.0. - YAML loader and saver now supports the "interchange" section. Any unknown keys under that section will be ignored upon load and will generate a warning but won't throw. - Generic str key/value loader/saver is extended for re usability (and fixed incorrect throw message). - since the amf keywords are separated by newline characters, the newline sanitizer that was used for the description is also generalized and applied to all of the current and possible future interchange fields. - ColorSpace_test.cpp file updated to test the current state and behavior of the API. - ComputeValues function in the CPUProcessor_tests.cpp was taking the linenumber as as template parameter. This was a very bad idea as that means each invocation of the function would create a separate copy of the function which was causing all sorts of issues in the debugger and failing to compile when the line numbers are not constants (happens in JIT debug sessions). Fixed by making the line number a normal parameter. - Python ColorSpace object no longer takes the amf of icc parameters in the constructor. User needs to set them explicitely later on. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * - ocioconvert now writes the ColorIntropID attribute of of the output color space. - ociocheck now does extended validity check on the interopID string. - preliminary implementation of getColorSpaceFromInteropID(). Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * - Another cleanup pass. After some deliberation, we decided to remove getColorSpaceFromInteropID() which will be done in a later pass. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * - Config::getColorSpaceFromInteropID() function is removed. - another round of cleanup. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * minor comment fix Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * minor fixes to unknown interchange key warning and its unit test. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * - Adding the missing interop_id validation check along with couple of unit-tests. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * - typo fix and minor cleanup Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * - Looks like Doxygen doesn't like URLs in the doxygen comment section. Removing the url to see if this fixes the CI issue. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * - minor typo fix Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * - deduplicating the newline sanitize code in OCIOYaml.cpp - exposing the interchange attributes as a standard python dictionary through the "interchangeAttributes" read-only property. - adding python tests on the new interchangeAttributes property. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * - per code-review, converting the interchangeAttributes propery on python colorspace object to getInterchangeAttributes() function to stick with the existing conventions. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> --------- Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> Co-authored-by: Doug Walker <doug.walker@autodesk.com>
…oundation#2186) * Enhance active display/view list API Signed-off-by: Doug Walker <doug.walker@autodesk.com> * Update ocioview to use new API Signed-off-by: Doug Walker <doug.walker@autodesk.com> * Fix python arg name Signed-off-by: Doug Walker <doug.walker@autodesk.com> --------- Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
cozdas
force-pushed
the
ozdasc/bumpOpenEXR34
branch
2 times, most recently
from
4e5bee7 to
e4ac68f
Compare
- Bump up recommended OpenEXR to 3.4.0 Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
cozdas
force-pushed
the
ozdasc/bumpOpenEXR34
branch
from
e4ac68f to
13f8f64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP