Skip to content

Conversation

@yvesfracari
Copy link

Description

This PR includes the Base and Arb COW tokens on the snapshot voting strategies and refactors all the strategies' names to erc20-balance-of-with-delegation to the strategy fits in the max length (8).

Changes

  • Add the Arb and Base bridged COW tokens into the settings.
  • Refactor all strategies to use erc20-balance-of-with-delegation to reduce total strategy length.

How to test

  1. Check that the erc20-balance-with-delegation returns the sum of the token balance and the delegations by using the playground.
  2. Do the same for arbitrum and base strategies.
  3. Check this testing space created with the new strategies. Note: on this space strategy we added a additional delegationSpace to sync with the main space delegations. This param by default is equal to the strategy space and that is why is not added on the PR.

@github-actions
Copy link

github-actions bot commented Jan 13, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@yvesfracari
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Copy link

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've tested this new settings at Snapshot and it works well. As mentioned in the forum discussion with these changes delegators can't override their delegate vote anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants