feat: pod integration #3910
feat: pod integration #3910
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
MartinquaXD
left a comment
MartinquaXD
left a comment
There was a problem hiding this comment.
Sorry for the late review. 🙇
| } | ||
| }; | ||
|
|
||
| let solve_response = dto::SolveResponse::new(score.clone(), solver); |
There was a problem hiding this comment.
Note to myself: we need to think about an upgrade path in case we have to change the response format in the future. Likely the same way ethereum handles hardforks (pick some auction_id at which all nodes should use the new format).
| self.config | ||
| .pod | ||
| .as_ref() | ||
| .map(|pod| pod.auction_contract_address) |
There was a problem hiding this comment.
Isn't this equivalent?
| self.config | |
| .pod | |
| .as_ref() | |
| .map(|pod| pod.auction_contract_address) | |
| self.config.pod?.auction_contract_address |
There was a problem hiding this comment.
No, but I refactored to this one:
Some(self.config.pod.as_ref()?.auction_contract_address)
There was a problem hiding this comment.
Would be good to separate out the playground changes into a separate PR.
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
2 participants
Description
Integration of pod network
Changes
This PR adds pod integration allowing solver to determine auction winner in a decentrilized shadow way.
When a solver has computed a solution, it also submits it to pod network.
Asynchronously it then waits for the auction to end, fetches all the bids from pod network and compute winner selection in the same way the autopilot does.
No existing functionality was replaced/updated. This PR only integrates the pod network in shadow mode.
How to test
A second baseline was added in playground. All tracing logs related to pod have the prefix
[pod]