Opera sniff be gone! #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Opera <10 uses event.domain instead of event.origin and excludes the protocol - Tested and confirmed working in Opera 9.64, 10.63 and 11.5
|
Ben, this old sniff actually breaks oldspice.com for Opera users now. To reproduce:
Expected: page opens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the need for forking the code in Opera.
Opera <10 uses event.domain rather than event.origin and it also excluded the URL protocol.
So I pointed e.origin to e.domain and stripped source_origin string of the URL protocol if the browser supports e.domain.
Tested and confirmed working in Opera 9.64, 10.63 and 11.5