fix(cli): build/start commands for Atomic projects on Node < 20.19.0 #1520
+346
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI-generated Atomic projects fail to build or start on Node < 20.19.0 due to ES module handling differences when Stencil internally converts ES imports to CommonJS
require()calls for the@coveo/create-atomic-rollup-pluginpackage.Changes
Detection and patching logic (
createAtomicProject.ts):shouldAddExperimentalDetectModuleFlag()to detect Node < 20.19.0 using semverpatchPackageJsonScripts()to inject--experimental-detect-moduleflag into generated project'sbuildandstartscriptscreateAtomicApp()to apply patch after successful project creationPattern matching:
stencilcommand (regex:^\s*stencil\b)stencil→node --experimental-detect-module ./node_modules/.bin/stencilError handling:
Example
Before (generated project fails on Node 20.18.0):
{ "scripts": { "start": "stencil build --dev --watch --serve", "build": "stencil build && node deployment.esbuild.mjs" } }After (auto-patched on Node < 20.19.0):
{ "scripts": { "start": "node --experimental-detect-module ./node_modules/.bin/stencil build --dev --watch --serve", "build": "node --experimental-detect-module ./node_modules/.bin/stencil build && node deployment.esbuild.mjs" } }Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zipnode install.js(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.