Skip to content

Support mixed canonical paths #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jtratner wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support mixed canonical paths #142

jtratner wants to merge 1 commit into from

Conversation

@jtratner
Copy link
Contributor

@jtratner jtratner commented Apr 13, 2021

Currently when you try to use a path like dx://someproj:file-123, you get an error about data not found:

NotFoundError: No data object was found for the given path (dx://myproj:file-G0GYf0Q0BqQ4kbBfJvGgFG4K) on DNAnexus

This just fixes it to check if valid dxid and then returns it.

@jtratner jtratner requested a review from pkaleta April 13, 2021 03:02
pkaleta
pkaleta approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@pkaleta pkaleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pkaleta pkaleta pkaleta approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtratner @pkaleta