updating dxpy3 to dxpy #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkaleta
approved these changes
Jun 13, 2019
Contributor
pkaleta
left a comment
pkaleta
left a comment
There was a problem hiding this comment.
LGTM. Is there anything remaining to do here before we merge?
added 2 commits
June 13, 2019 09:35
Collaborator
Author
|
I had included the release notes along with other small PRs in this single PR: #114 . But since the other ones still need reviewing, adding the release notes separately here. I think this is good to merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jtratner CC @pkaleta
Since DNAnexus has integrated dxpy3 into dxpy, makes sense to get rid of dxpy3 from stor.
Passed unit and integration tests.