Merged
Conversation
Co-authored-by: costiash <63783894+costiash@users.noreply.github.com> Agent-Logs-Url: https://github.com/costiash/CognivAgent/sessions/ecb9b441-bb6f-433f-8f29-44ee329844ae
|
This PR adds a GitHub Pages landing page. See full review below. |
PR Review: feat: add github pages site scaffold — This PR adds a GitHub Pages landing page with a deployment workflow, SEO metadata, and a polished static site. No backend/app code touched. Positive: Well-structured workflow (path-scoped triggers, concurrency control, workflow_dispatch). Strong SEO (OG, Twitter Card, JSON-LD, canonical URL, robots.txt, sitemap.xml). Responsive design (980px/720px breakpoints). Security-conscious messaging. Issues: (1) PR description empty - fill in template. (2) Stale test count - page shows 914 but README says 910, use 900+. (3) External links open in same tab - add target=_blank rel=noopener noreferrer. (4) No favicon - add cognivagent-icon.svg to docs/. (5) Missing skip-to-content link for a11y. (6) Preload critical Google Font for LCP. (7) Add sitemap link in HTML head. (8) sitemap.xml has single entry - add guides if needed. (9) No environment protection on workflow - fine for docs. Security: Static HTML only, no XSS surface, permissions correctly scoped, no secrets. Summary: Solid scaffold. Main items: fill PR description, fix test count, add target blank to external links. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent-Logs-Url: https://github.com/costiash/CognivAgent/sessions/ecb9b441-bb6f-433f-8f29-44ee329844ae
Summary
Brief description of what this PR does.
Related Issue
Closes #(issue number)
Type of Change
Changes Made
Testing
Describe how you tested these changes:
Screenshots (if applicable)
Checklist
uv run pytestand all tests passuv run mypy .with no errorsuv run ruff check .with no errorsAdditional Notes
Any additional information reviewers should know.