Skip to content

perf(mempool): collapse queue Push to single write-lock #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
daps94 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf(mempool): collapse queue Push to single write-lock #1069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions mempool/internal/queue/queue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,17 +66,17 @@ func (iq *Queue[Tx]) Push(tx *Tx) <-chan error {
sub := make(chan error, 1)

if tx == nil {
// TODO: when do we expect this to happen?
close(sub)
return sub
}
if iq.isFull() {

iq.lock.Lock()
if iq.maxSize > 0 && iq.queue.Len() >= iq.maxSize {
iq.lock.Unlock()
sub <- ErrQueueFull
close(sub)
return sub
}

iq.lock.Lock()
iq.queue.PushBack(insertItem[Tx]{tx: tx, sub: sub})
iq.lock.Unlock()

Expand Down Expand Up @@ -168,14 +168,6 @@ func (iq *Queue[Tx]) insertTxs(txs []*Tx) []error {
return errs
}

// isFull returns true if the queue is at capacity and cannot accept anymore
// Tx's, false otherwise.
func (iq *Queue[Tx]) isFull() bool {
iq.lock.RLock()
defer iq.lock.RUnlock()
return iq.queue.Len() >= iq.maxSize
}

// Close stops the main loop of the queue.
func (iq *Queue[Tx]) Close() {
close(iq.done)
Expand Down
Loading