test: add unit tests for SectionEditor and GithubConnect (#61)#67
Merged
corvid-agent merged 3 commits intomainfrom Mar 1, 2026
Merged
test: add unit tests for SectionEditor and GithubConnect (#61)#67corvid-agent merged 3 commits intomainfrom
corvid-agent merged 3 commits intomainfrom
Conversation
Adds 42 new tests across 3 previously untested components: - TableEditorComponent (16 tests): cell change, addRow, removeRow, moveRowUp/Down, no-op edge cases, empty state, immutability - SectionNavComponent (12 tests): nav item rendering, active state, click emission, level classes, dynamic updates - SpecPreviewComponent (14 tests): markdown rendering, validation panel states (valid/invalid/warnings), error/warning classes Contributes to #61 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
37 tests covering heading editing, navigation (prev/next/frontmatter), structured editing mode (table + text blocks), CodeMirror mode detection, section change handling, accessibility (ARIA labels/roles), and edge cases. Closes #61 (partial — SectionEditorComponent) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
47 tests covering: idle state display, PAT form toggle and validation, signal state management, device flow (user code display, polling status, cancel), connected state (repo label, pull/disconnect buttons, loading), OAuth signed-in state (repo browser, manual form), connection actions (PAT vs OAuth connect, sign in/out, disconnect, pull specs), error display, and accessibility (ARIA labels, expanded state, alert roles). Closes #61 (partial — GithubConnectComponent) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SectionEditorComponent— heading editing, navigation (prev/next/frontmatter), structured editing mode (table + text blocks), CodeMirror mode detection, section change handling, accessibility, and edge casesGithubConnectComponent— idle state, PAT form, device flow (user code, polling, cancel), connected state, OAuth signed-in state, connection actions, error display, and accessibilityPartially addresses #61 — covers the two highest-priority untested components.
Test plan
ng test --watch=false)🤖 Generated with Claude Code