Skip to content

Feat: Crew Module #15

Open
rudestewing wants to merge 14 commits intocoronatorid:masterfrom
rudestewing:master
Open

Feat: Crew Module #15
rudestewing wants to merge 14 commits intocoronatorid:masterfrom
rudestewing:master

Conversation

@rudestewing
Copy link
Copy Markdown
Contributor

  • Auth page for crew
  • authorization client-side redirection
  • crew dashboard

@insomnius
Copy link
Copy Markdown
Contributor

Ada conflict @rudestewing .

Comment thread components/BadgeReportStatus.js Outdated
Comment thread components/BadgeReportStatus.js Outdated
rudestewing and others added 3 commits January 17, 2021 10:49
Co-authored-by: Muhammad Arief Rahman <awc.aliana@gmail.com>
Co-authored-by: Muhammad Arief Rahman <awc.aliana@gmail.com>
@rudestewing
Copy link
Copy Markdown
Contributor Author

Ada conflict @rudestewing .

sudah ya pack ~

Comment thread .env.local.example Outdated
Comment thread components/Badge.js
Comment thread components/Badge.js
return allowedType.name == type
})

return _type ? _type : allowedTypes[0]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harusnya gak ada case kayak gini bukan @rudestewing ? Jika type-nya gak ada di allowedType akan di return default, jadi ini langsung bisa return _type

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gw blm paham maksud lu

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maksud gue kalo diubah kayak gini masalah kah?

    return allowedTypes[type] ?? allowedTypes['default']

    const _type = allowedTypes.find((allowedType) => {
      return allowedType.name == type
    })

    return _type

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seharusnya _type itu gk ada sih

function selectedType() {
return allowedTypes[type] ?? allowedTypes['default']
}
jadi kodenya harusnya sampe sini doang cuma gw lupa apus yg bawah
lebih simple

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boleh @rudestewing sesuai rekomendasi lu.

Comment thread components/BadgeReportStatus.js
}

function selectedStatus() {
return allowedStatuses[status] ?? allowedStatuses[0]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default-nya gini aja @rudestewing

Suggested change
return allowedStatuses[status] ?? allowedStatuses[0]
return allowedStatuses[status] ?? allowedStatuses[2]


const BadgeReportStatus = ({status}) => {

const allowedStatuses = {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kenapa gak pake array aja?

Comment thread components/EmptyData.js Outdated
rudestewing and others added 2 commits January 18, 2021 06:58
Co-authored-by: Muhammad Arief Rahman <awc.aliana@gmail.com>
Co-authored-by: Muhammad Arief Rahman <awc.aliana@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants