Add CONFIRM dialog guard for Run Migration button in Dev Tools#420
Open
CasperL1218 wants to merge 1 commit intophase1-all-mergesfrom
Open
Add CONFIRM dialog guard for Run Migration button in Dev Tools#420CasperL1218 wants to merge 1 commit intophase1-all-mergesfrom
CasperL1218 wants to merge 1 commit intophase1-all-mergesfrom
Conversation
Replaces window.confirm() with a MUI Dialog that requires the admin to type 'CONFIRM' before the schema migration can proceed, preventing accidental batch-writes to all apartment records.
Member
|
[diff-counting] Significant lines: 49. |
bryanshao07
reviewed
Mar 23, 2026
bryanshao07
left a comment
bryanshao07
left a comment
There was a problem hiding this comment.
Looks good! Adding the "CONFIRM" button feature is a good safeguarding feature. One small thing might be making the confirmation check case-insensitive with .toUpperCase() for usability, or making it super clear that it must be in all caps. Good overall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONFIRM before proceeding
Test Plan
Notes
This PR should be merged after PR #418 (phase1-all-merges), which introduced the Dev Tools tab. Base branch is set
to phase1-all-merges for that reason — retarget to main once #418 merges.
Breaking Changes