Skip to content

Flag deprecated endpoints for saving apartments and landlords#414

Open
laurenp-2 wants to merge 1 commit intomainfrom
deprecated-endpoints
Open

Flag deprecated endpoints for saving apartments and landlords#414
laurenp-2 wants to merge 1 commit intomainfrom
deprecated-endpoints

Conversation

@laurenp-2
Copy link
Copy Markdown

Summary

This pull request is the first step towards deprecating old save/check endpoints and improving the UX for apartment saves.
-[x] Marked endpoints related to saving apartments and landlords (/api/check-saved-apartment, /api/check-saved-landlord) as deprecated in the backend code. These endpoints are still functional but will be replaced in future updates with more reliable logic.
-[x] Updated the frontend for the apartment page and cards so that the bookmark icon reflects hover state instead of the saved state; hovering over the icon now shows the “saved” icon visually, while the actual save/unsave logic is handled on click.

- mark endpoints related to saving apartments and landlords as deprecated in the backend code.
- fix hover state for save icon on apartment page.
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Lauren Pothuru seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dti-github-bot
Copy link
Copy Markdown
Member

[diff-counting] Significant lines: 91.

@parsa-tehranipoor
Copy link
Copy Markdown
Contributor

This PR looks great! Really good that you added the deprecated tag on top of the already existing documentation for those routes. One thing I would add is that below some of the newly deprecated routes, there are some comments that attempt to describe the route itself. These comments would be better placed on top of the route with its correlated documentation, which would follow our codebase's coding conventions. Outside of that, great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants