Flag deprecated endpoints for saving apartments and landlords#414
Open
Flag deprecated endpoints for saving apartments and landlords#414
Conversation
- mark endpoints related to saving apartments and landlords as deprecated in the backend code. - fix hover state for save icon on apartment page.
|
Lauren Pothuru seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Member
|
[diff-counting] Significant lines: 91. |
Contributor
|
This PR looks great! Really good that you added the deprecated tag on top of the already existing documentation for those routes. One thing I would add is that below some of the newly deprecated routes, there are some comments that attempt to describe the route itself. These comments would be better placed on top of the route with its correlated documentation, which would follow our codebase's coding conventions. Outside of that, great job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is the first step towards deprecating old save/check endpoints and improving the UX for apartment saves.
-[x] Marked endpoints related to saving apartments and landlords (/api/check-saved-apartment, /api/check-saved-landlord) as deprecated in the backend code. These endpoints are still functional but will be replaced in future updates with more reliable logic.
-[x] Updated the frontend for the apartment page and cards so that the bookmark icon reflects hover state instead of the saved state; hovering over the icon now shows the “saved” icon visually, while the actual save/unsave logic is handled on click.