Fix Firebase User import and add Apartment component documentation#413
Open
CasperL1218 wants to merge 1 commit intomainfrom
Open
Fix Firebase User import and add Apartment component documentation#413CasperL1218 wants to merge 1 commit intomainfrom
CasperL1218 wants to merge 1 commit intomainfrom
Conversation
- Add firebase/app and firebase/auth imports to ApartmentPage.tsx to
resolve 'User' type error
- Add JSDoc documentation to AptInfo.tsx, Info.tsx, and MapInfo.tsx
following project documentation guidelines
Member
|
[diff-counting] Significant lines: 46. |
laurenp-2
approved these changes
Dec 8, 2025
laurenp-2
left a comment
laurenp-2
left a comment
There was a problem hiding this comment.
Great documentation addition! The JSDoc comments really improve clarity and will help future contributors understand the code much faster :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Firebase import fix and Apartment component documentation.
error
Test Plan
yarn workspace frontend tsc --noEmit)Notes
Documentation follows project guidelines from FA24.