Skip to content

Saved Folders Feature #410

Open
laurenp-2 wants to merge 17 commits intomainfrom
folder_system
Open

Saved Folders Feature #410
laurenp-2 wants to merge 17 commits intomainfrom
folder_system

Conversation

@laurenp-2
Copy link
Copy Markdown

@laurenp-2 laurenp-2 commented Oct 27, 2025

Summary

This pull request implements the folder saving feature, where users can assign apartments to custom folders.

  • Implemented api endpoints for the creation, renaming, and deletion of folders
  • Implemented api endpoints to add and remove apartments to folders
  • Implemented a frontend Folders page where users can see all their folders and the apartments saved to them
  • Added a 'Save to folder' popover in apartment pages and cards

Test Plan

Screenshots of the Folders page and Save to Folder modal
Screenshot 2025-12-07 at 9 53 39 PM
Screenshot 2025-12-07 at 9 54 12 PM
Screenshot 2025-12-07 at 9 54 34 PM

Postman was used to test the api endpoints and make sure the backend worked smoothly.

Lauren Pothuru added 2 commits October 22, 2025 17:26
- Implement folder page to display user folders
- Add folder card component for folder representation
- Added 'add to folder' button in apartment page
- Debugged authentication issues in folder operations
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 27, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ laurenp-2
❌ Lauren Pothuru


Lauren Pothuru seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dti-github-bot
Copy link
Copy Markdown
Member

dti-github-bot commented Oct 27, 2025

[diff-counting] Significant lines: 1911. This diff might be too big! Developer leads are invited to review the code.

@parsa-tehranipoor
Copy link
Copy Markdown
Contributor

Super cool feature Lauren! Your backend routes look really polished and nicely organized. You followed our coding conventions really well, which made understanding your work 10x easier. The UI from the screenshots above also looks really nice. Nice job!

@laurenp-2 laurenp-2 requested a review from CasperL1218 October 27, 2025 19:08
@laurenp-2 laurenp-2 changed the title Saved Folders Feature WIP: Saved Folders Feature Nov 17, 2025
Copy link
Copy Markdown
Contributor

@CasperL1218 CasperL1218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Code structure is organized, well-documented, and the inline component comments are helpful (e.g. AddToFolderPopover.tsx)
Some future points of consideration for feature expansions:

  • Shared folder ownership: The current document structure for folders uses a single user value, which will need to change to support co-ownership.
  • Proposed solution: Replace the string-based user field with an array to accommodate multiple users.

Implementation requirements:

  • change to user-id based query logic (@route GET /api/folders)
  • persistence logic for multiple owners (e.g. modified deletion in @route DELETE /api/folders/:folderId to remove specific users rather than deleting the entire folder).

These will be future requirements. Current implementation is great. Well done.

@laurenp-2 laurenp-2 changed the title WIP: Saved Folders Feature Saved Folders Feature Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants