Implement enable/disable for systemd #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreybutler
reviewed
Apr 3, 2017
Owner
coreybutler
left a comment
coreybutler
left a comment
There was a problem hiding this comment.
Looks pretty good... there were a couple of spots with logging the commands. I didn't know if that was for debugging purposes or a "feature". I'm OK with it either way, but I thought I'd mention it in case you wanted to modify anything before I merge this.
| } | ||
| var me = this; | ||
| var cmd = 'systemctl enable '+this.label; | ||
| console.log('Running %s...', cmd); |
Owner
There was a problem hiding this comment.
Is this supposed to be here or was it for debugging?
| } | ||
| var me = this; | ||
| var cmd = this._configFilePath()+' stop'; | ||
| console.log('Running %s...', cmd); |
Owner
There was a problem hiding this comment.
Is this supposed to be here or was it for debugging?
| cmd = '/sbin/chkconfig '+this.label+' off'; | ||
| } | ||
| var me2 = me; | ||
| console.log('Running %s...', cmd); |
Owner
There was a problem hiding this comment.
Is this supposed to be here or was it for debugging?
Author
|
The logs were intentional since it seemed inconsistent to log for some execs but not other very similar ones. |
|
Pls, merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes a bit of non-invasive cleanup.