feat/fix: minor changes/fixes #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR makes minor changes to type definitions and webpack asset loader configuration. The changes extend the htmlTemplatePath type to accept falsy values for disabling the HTML plugin, update its documentation, and simplify the asset loader configuration by removing a redundant generator setting.
Changes:
- Extended
htmlTemplatePathtype to includenull,undefined, andfalsevalues with updated documentation - Removed custom generator configuration from the
/assets\//loader rule
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/types.ts | Updated htmlTemplatePath type to accept falsy values and added documentation about the default value and disabling behavior |
| src/blocks/loaders.ts | Removed the generator configuration for assets matching /assets\//, allowing them to use the global assetModuleFilename setting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.