This repository was archived by the owner on Sep 18, 2020. It is now read-only.
Open
Conversation
Fixup inconsistent use of FLAGS_mem and '_get_vm_opt MEM'. The user supplied FLAGS_mem is passed to write_vm_conf, and it should take presidence over built-in values returned by '_get_vm_opt MEM'. Signed-off-by: Geoff Levand <geoff@infradead.org>
ARM64 builds tend to run out of memory with only 1024 MiB, so replace the IMG_DEFAULT_MEM constant with a new function get_vm_mem that returns a default memory size based the board. Signed-off-by: Geoff Levand <geoff@infradead.org>
The replacement of DEFAULT_MEM with get_vm_mem makes all of this unused. Signed-off-by: Geoff Levand <geoff@infradead.org>
Contributor
Author
|
Rebased to latest. |
ajeddeloh
approved these changes
May 23, 2018
Contributor
ajeddeloh
left a comment
ajeddeloh
left a comment
There was a problem hiding this comment.
LGTM. I'm all for cleaning out cruft. Tests this with a build_image and image_to_vm and it worked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix up inconsistent use of FLAGS_mem and '_get_vm_opt MEM', add function get_vm_mem to get more memory for arm64, and remove unused files in the lib directory.