This repository was archived by the owner on May 7, 2021. It is now read-only.
platform: make machine check errors more useful #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not claim the machine is not reachable when it actually is and is just booting. If it times out while booting, also log active jobs.
arithx
suggested changes
Jun 17, 2019
Contributor
arithx
left a comment
arithx
left a comment
There was a problem hiding this comment.
Sorry for the late review, fell off my radar on Friday.
| out, stderr, err := m.SSH("systemctl is-system-running") | ||
| if !bytes.Contains([]byte("initializing starting running stopping"), out) { | ||
| return nil // stop retrying if the system went haywire | ||
| return fmt.Errorf("machine reached a bad state: %s, %v, %s", out, err, stderr) |
Contributor
There was a problem hiding this comment.
We'll need to build a mechanism for detecting if we're running kola spawn. As this code currently is we cannot spawn into machines in a degraded state any longer with this patch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not claim the machine is not reachable when it actually is and is
just booting. If it times out while booting, also log active jobs.