Skip to content

Conversation

@ashcrow
Copy link
Member

@ashcrow ashcrow commented Dec 10, 2019

Instead of using a submodule we split out the mantle specific code (kola, ore, etc..) into it's own container image which cosa then layers on.

Requires:

TODO

  • Update FROM in Dockerfile

@ashcrow ashcrow requested review from darkmuggle and jlebon December 10, 2019 18:47
Instead of using a submodule we split out the mantle specific
code (kola, ore, etc..) into it's own container image which
cosa then layers on.

Signed-off-by: Steve Milner <smilner@redhat.com>
@jlebon
Copy link
Member

jlebon commented Dec 10, 2019

I think a multi-stage build would be cool for this. The base Fedora image cosa uses I think should belong here instead of indirectly via the mantle Dockerfile.

Really all we want are the final Go binaries, so we could just copy them in. Not sure if Quay supports multi-stage builds, though OpenShift does, and we have a coreos namespace there where we could build this.

@ashcrow
Copy link
Member Author

ashcrow commented Dec 10, 2019

Good points @jlebon. Looking at the card for this it's a bit confusing as to if this is really meant to be layered or if the cosa container should use the mantle container. In any case, the mantle one has to merge first. Thanks for the early review!!

@cgwalters
Copy link
Member

I think this one is obsolete now with the merge.

@openshift-ci-robot
Copy link

@ashcrow: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcajka pushed a commit to jcajka/coreos-assembler that referenced this pull request Mar 24, 2020
kola/tests/rpmostree: use different pkg for 'rpm-ostree (un)install'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants