packit: add initial support #1003
Conversation
|
Failed to load packit config file: For more info, please check out the documentation or contact the Packit team. You can also use our CLI command |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds an initial packit configuration for automating downstream packaging. The configuration has a few issues that could prevent it from working as intended. I've identified a couple of critical issues related to the spec file handling and job triggers that need to be addressed. I've also included some suggestions to improve the configuration's maintainability and use packit's features more effectively. My feedback focuses on establishing a clear source of truth for the spec file and ensuring the job triggers are correctly configured for the desired workflow.
.packit.yaml
Outdated
| post-upstream-clone: | ||
| - wget https://src.fedoraproject.org/rpms/rust-bootupd/blob/rawhide/f/rust-bootupd.spec |
There was a problem hiding this comment.
The post-upstream-clone action downloads the spec file from the Fedora rawhide branch. This will overwrite any spec file present in this repository, making local changes to the spec file ineffective. This action should be removed to use the spec file from this repository as the source of truth. This also makes the configuration simpler and avoids a circular dependency where the spec file is fetched from downstream and then proposed back.
There was a problem hiding this comment.
Huh, wow. Yes I think this is probably right.
Though honestly I still disagree with packit's focus on maintaining spec files in upstream by default. It's convenient for projects that are mainly Fedora-derivative only. There's just a deep fundamental conflict with distros owning their build rules.
IOW, yes we can probably drop this if we're maintaining the spec upstream.
There was a problem hiding this comment.
Maybe I should use contrib/packaging/bootupd.spec instead.
.packit.yaml
Outdated
| - fedora-all | ||
|
|
||
| - job: bodhi_update | ||
| trigger: commit |
There was a problem hiding this comment.
The bodhi_update job is currently triggered on commit. This will cause it to run for every commit to a dist-git branch, even before a build has been completed in Koji, which will likely lead to failures. This job should be triggered after a successful Koji build.
trigger: koji_build
HuijingHei
force-pushed
the
enable-packit
branch
from
b3c0462 to
7b45c08
Compare
HuijingHei
force-pushed
the
enable-packit
branch
2 times, most recently
from
7a312b8 to
a6b2612
Compare
HuijingHei
force-pushed
the
enable-packit
branch
from
a6b2612 to
4872c13
Compare
This is part of Fedora BootLoaderUpdatesPhase1: https://fedoraproject.org/wiki/Changes/BootLoaderUpdatesPhase1
Extract duplicated ESP mounting, validation, and copying logic from install() and package_mode_copy_to_boot_impl() into shared helper function to eliminate dupe code.
Addressing review: add unit test that installs shim into a container and ensures that the files are properly setup in the right place
HuijingHei
force-pushed
the
enable-packit
branch
from
4872c13 to
2a9b4be
Compare
Run `bootupctl backend copy-to-boot` in posttans for F44+
HuijingHei
force-pushed
the
enable-packit
branch
from
2a9b4be to
62e1ddd
Compare
HuijingHei
force-pushed
the
enable-packit
branch
4 times, most recently
from
81f9ef7 to
661ffa8
Compare
HuijingHei
force-pushed
the
enable-packit
branch
from
661ffa8 to
48d7a78
Compare
3 participants
This config is setup to target downstream job automation.