This repository was archived by the owner on Sep 21, 2023. It is now read-only.
Include real wget to avoid busybox bugs included in alpine 3.6+#20
Open
whereisaaron wants to merge 1 commit intocoreos:masterfrom
Open
Include real wget to avoid busybox bugs included in alpine 3.6+#20whereisaaron wants to merge 1 commit intocoreos:masterfrom
whereisaaron wants to merge 1 commit intocoreos:masterfrom
Conversation
The busybox imitation wget in alpine 3.6 appears to have problems with important AWS contexts, like `wget -O - -q http://169.254.169.254/2016-09-02/meta-data/instance-id` An effective workaround is to include the alpine real 'wget' package. This patch does that. (Alternatively, reverting to alpine 3.5 apparently also fixes the busybox 'wget') kubernetes-retired/kube-aws#1369 gliderlabs/docker-alpine#292 gliderlabs/docker-alpine#344 https://git.busybox.net/busybox/commit/?id=a6f8651911716d1d1624712eb19e4f3608767c7e apache/openwhisk#3715 (It would be nice to have version tags in the 'awscli' repo so people could e.g. (a) revert to the working release, or (b) if this full wget breaks for someone who was counting of some property of the busybox wget.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The busybox imitation wget in alpine 3.6 appears to have problems with important AWS contexts, like
wget -O - -q http://169.254.169.254/2016-09-02/meta-data/instance-idon the newer m5/c5 gen instancesAn effective workaround is to include the alpine real 'wget' package. This patch does that.
Alternatively, reverting to alpine 3.5 apparently also fixes the busybox 'wget'.
kubernetes-retired/kube-aws#1369
gliderlabs/docker-alpine#292
gliderlabs/docker-alpine#344
https://git.busybox.net/busybox/commit/?id=a6f8651911716d1d1624712eb19e4f3608767c7e
apache/openwhisk#3715
(It would be nice to have version tags in the 'awscli' repo so people could e.g. revert to the working release, or if adding this full wget breaks for someone who was counting of some property of the busybox wget.)