sdk: add per-function updateRevision for minimum firmware detection [SDK-60] #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplexer
force-pushed
the
add-update-revision-support
branch
from
b45e026 to
74fce16
Compare
Decouple symbol table ordering (addedRevision) from firmware compatibility by adding an updateRevision field to exported_symbols.json. After linking, the build system analyzes the app ELF to find which SDK functions are used, computes the max updateRevision among them, and patches the binary's SDK version field. This allows apps compiled with a newer SDK to target older firmware when they only use older APIs. Revisions <= 89 map to minor 0x56 (historical cutoff); revisions >= 90 map directly to the minor byte (90 = 0x5A, 91 = 0x5B, etc.). Signed-off-by: Joshua Jun <joshuajun@proton.me>
jplexer
force-pushed
the
add-update-revision-support
branch
from
74fce16 to
45bfc7b
Compare
Member
Author
|
Confirmed working by rebasing moddable repo onto this, compiling some apps with it and seeing if non-moddable api applications run on a older fw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple symbol table ordering (addedRevision) from firmware compatibility by adding an updateRevision field to exported_symbols.json. After linking, the build system analyzes the app ELF to find which SDK functions are used, computes the max updateRevision among them, and patches the binary's SDK version field. This allows apps compiled with a newer SDK to target older firmware when they only use older APIs.
Revisions <= 89 map to minor 0x56 (historical cutoff); revisions >= 90 map directly to the minor byte (90 = 0x5A, 91 = 0x5B, etc.).
Basically a version of #577 that should not break existing behavior