-
Notifications
You must be signed in to change notification settings - Fork 15
[Refactor] Introduce NeuraAttributes.h to manage attribute constants #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tancheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup~!
|
Can we also have following in the header file? dataflow/lib/NeuraDialect/Transforms/GenerateCodePass.cpp Lines 204 to 224 in 2a6fdfa
And anything introduced from https://github.com/coredac/dataflow/pull/157/changes |
|
Hi @tancheng, thanks for the suggestions! I have addressed both points in the latest commits:
Please verify and resolve the conversation if it looks good. |
|
Thanks~! |
This PR addresses part of #145 by introducing a centralized header NeuraAttributes.h and replacing a subset of hardcoded magic strings in the lib/ directory.