Skip to content

Conversation

@ShangkunLi
Copy link
Collaborator

In this pr,

  • fix some bugs in canonicalize-live-in pass
  • enable logic operations' fusion
  • run the e2e spmv kernel

@ShangkunLi ShangkunLi self-assigned this Jan 17, 2026
@ShangkunLi ShangkunLi linked an issue Jan 17, 2026 that may be closed by this pull request
@tancheng
Copy link
Contributor

hmmm, why this PR includes @n0thingNoob's PR? Can we make the fix be standalone?

@n0thingNoob
Copy link
Collaborator

hmmm, why this PR includes @n0thingNoob's PR? Can we make the fix be standalone?

Because this is a new test on my branch that hasn’t been merged into main yet. This PR fixes the bug reported in issue #238. And #238 is a bug that shows up in CI but doesn’t reproduce on my local machine.

@ShangkunLi
Copy link
Collaborator Author

hmmm, why this PR includes @n0thingNoob's PR? Can we make the fix be standalone?

Hi~ @tancheng, now I only push the changes that I made to this pr. After sync with this pr, @n0thingNoob should be able to run the spmv test.

@ShangkunLi ShangkunLi merged commit ea71c57 into coredac:main Jan 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spmv test compile issue

3 participants