Mohamed Boucadair's review #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EskoDijk
reviewed
Dec 16, 2025
EskoDijk
reviewed
Dec 16, 2025
EskoDijk
reviewed
Dec 16, 2025
EskoDijk
requested changes
Dec 16, 2025
Collaborator
EskoDijk
left a comment
EskoDijk
left a comment
There was a problem hiding this comment.
Thanks @marco-tiloca-sics , proposed a few sentence edits - rest is ok!
Co-authored-by: Esko Dijk <EskoDijk@users.noreply.github.com>
Co-authored-by: Esko Dijk <EskoDijk@users.noreply.github.com>
Co-authored-by: Esko Dijk <EskoDijk@users.noreply.github.com>
EskoDijk
approved these changes
Dec 17, 2025
Collaborator
EskoDijk
left a comment
EskoDijk
left a comment
There was a problem hiding this comment.
For some reason I don't see my prior comments anymore here, but I'll just approve assuming it's ok now.
boucadair
approved these changes
Dec 19, 2025
boucadair
left a comment
boucadair
left a comment
There was a problem hiding this comment.
Thank for meticulously tracking review points.
Look good to me. I have one minor suggestion, but I'm OK even without it.
|
|
||
| In case a single client has sent multiple group requests and concurrent CoAP transactions are ongoing, the responses received by that client are matched to an active request using only the Token value. Due to UDP level multiplexing, the UDP destination port number of the response MUST match to the client endpoint's UDP port number, i.e., to the UDP source port number of the client's request. | ||
|
|
||
| Note that some responses to a group request might be filtered out and not reach the client if a NAT device is used with restrictive filtering in place. For example, this is the case if the NAT device employs "Endpoint-Dependent Filtering" (see {{Section 2.6 of RFC5128}}), i.e., the combination of "Address-Dependent Filtering" and "Address and Port-Dependent Filtering" as defined in {{Section 5 of RFC4787}}. |
There was a problem hiding this comment.
Suggested change
| Note that some responses to a group request might be filtered out and not reach the client if a NAT device is used with restrictive filtering in place. For example, this is the case if the NAT device employs "Endpoint-Dependent Filtering" (see {{Section 2.6 of RFC5128}}), i.e., the combination of "Address-Dependent Filtering" and "Address and Port-Dependent Filtering" as defined in {{Section 5 of RFC4787}}. | |
| Note that some responses to a group request might be filtered out and not reach the client if a NAT device is used with restrictive filtering in place. For example, this is the case if the NAT device employs "Address and Port-Dependent Filtering" (see {{Section 5 of RFC4787}}), i.e., the combination of "Address-Dependent Filtering" and "Address and Port-Dependent Filtering" as defined in {{Section 5 of RFC4787}}. |
The OLD is OK but better to use BEHAVE terms as these are well-established in the industry.
Collaborator
There was a problem hiding this comment.
@boucadair Thanks, I like this suggestion. Will be included!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the review from Mohamed Boucadair archived at https://mailarchive.ietf.org/arch/msg/core/6bjFRbSwzAvfdQqupIn9hCxB_OA/
(The separate PR #56 tracks the updates that address the comment on "dual-stack" and on the relation between application groups and CoAP groups)