fix: lto in windows, rustc allocator

[cordx56]

Type Of Change

• Bug fix
• New feature
• Documentation update
• Enhancement
• Breaking change
• Other

[MuntasirSZN]

Use insta crate pls (as i see you are doing snapshot testing)

[cordx56]

@MuntasirSZN

Use insta crate

I thought insta crate is for unit test. However, this PR implements E2E test.

[MuntasirSZN]

@MuntasirSZN

Use insta crate

I thought insta crate is for unit test. However, this PR implements E2E test.

So you want to use the final binary and use the show command then check output = snapshot? Well, the part before output can be a function that builds, runs and gives the output, then we use insta to do snapshotting.

Yes its e2e, I am just asking to do it in rust using insta.....

[cordx56]

I don’t know the motivation to use Insta because we may have to change some APIs to test RustOwl using Insta.
But we don’t have to use shell scripts, so I can write it in Rust if it is the best practice.

[MuntasirSZN]

I don’t know the motivation to use Insta because we may have to change some APIs to test RustOwl using Insta. But we don’t have to use shell scripts, so I can write it in Rust if it is the best practice.

No we dont. Its simple. In rust, we call cargo to build it, then we use that binary to get output, then insta does its thing.

[cordx56]

But our RustOwl API doesn't written for insta E2E test.
And we need rustowlc binary before testing. How can I write the dependency that rustowlc should be built before rustowl test execution?

[MuntasirSZN]

But our RustOwl API doesn't written for insta E2E test. And we need rustowlc binary before testing. How can I write the dependency that rustowlc should be built before rustowl test execution?

Ummmm a bit of confusion? rustowl api is not written for e2e test? as I said, it will run normal commands, get the output and send to insta macro (one line) get output and send to insta. About build, that test will build rustowl BY INVOKING COMMANDS. (Command::new)

[MuntasirSZN]

You should look at insta first.

[cordx56]

I already looked insta, and I couldn’t find any command execution macros. I think insta crate is not for E2E test.

[MuntasirSZN]

We will do command exceution with std (and maybe some other crates) and everything else before checking if it similar to snapshot (insta will do tha).

[cordx56]

Where will we do the command execution? The test requires that rustowl is already built, so it cannot be written in RustOwl code.

[MuntasirSZN]

Where will we do the command execution? The test requires that rustowl is already built, so it cannot be written in RustOwl code.

Test execution flow:

• Build rustowl with cargo
• Then snapshot show whatever.

"ITS NOT RUSTOWL CODE I AM TELLING TO DO WHAT YOU ARE DOING IN THIS PR IN A TEST WITH RUST AND INSTA"

[cordx56]

So should I write test code in another new crate?

[MuntasirSZN]

So should I write test code in another new crate?

No.

Test macro
Call cargo build with command::new
Then call the debug rustowl
Then use insta to snapshot
Finish

[cordx56]

Inside RustOwl crate?

rustowl and rustowlc should be built before running tests, so should the user build RustOwl before testing?

[MuntasirSZN]

Uhhhhhhhhh let me do it myself......

[cordx56]

Okay, I will review it.

[MuntasirSZN]

@cordx56 done e3dc272

[MuntasirSZN]

I stop now. Lto in windows is not possible, even by rust.

rust-lang/rust#103595

No cross lang lto, as we need an EXACT LLVM toolchain (which is another hard task).

We keep on using normal no lto in windows.

[MuntasirSZN]

@cordx56 now review and merge

[MuntasirSZN]

@cordx56 Now I am lost. @cordx56