Conversation
- Optimize Loc::new() to eliminate string allocations during byte-to-char conversion - Replace HashMap with IndexMap for better cache performance in models - Use SmallVec for commonly small collections (ranges, statements, declarations) - Flatten cache structure with combined keys for better memory layout - Optimize merge operations to use HashSet for O(1) lookup instead of dedup_by - Add helper functions for efficient data structure conversions - Use more efficient parallel processing patterns Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
- Update miri_tests.rs to use constructors instead of direct struct initialization - Replace Vec::new() with appropriate SmallVec constructors in tests - Fix capacity assertions to match SmallVec minimums - Ensure all tests compile and run correctly with new optimized data structures Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
…omprehensive configuration Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
…timizations Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
chore: another clippy fix Update docs/cache-configuration.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Update src/bin/core/cache.rs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Update src/cache.rs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> remove allow unused
Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
…used code Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
… checks Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
…opying code Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MuntasirSZN
force-pushed
the
feat/test-frenzy
branch
from
ac912ba to
5719720
Compare
|
I hate to say this, but this PR has grown far too large. It’s difficult to review because it’s unclear when it will be completed, and the changes go well beyond the scope of refactoring. There are also many breaking changes. Another concern is that the changes haven’t been sufficiently discussed. Rather than incorporating many great changes all at once, I’d prefer to release updates regularly. To do that, each change should be thoroughly discussed and we need time to debug them properly. Of course, you’re welcome to implement and test various features in your own repository, but PRs should be submitted with appropriate granularity. This isn’t about the amount of code. They should be scoped by topic to facilitate discussion. Please understand that not all great changes will necessarily be supported by everyone. |
So what should i do now? I sent granular prs (stacked) and you wanted in a big pr. Now you want a granular one again? I can cherry-pick commits from start commit and you can merge one by one. That way is available. @cordx56 |
|
Also we are going to v1 which is a breaking change anyway. |
|
@cordx56 now you can review. I will do no more changes. xtask refactor is a bit "small", doesnt have fancy outputs, but functions. |
|
I will accomodate each edit ONE BY ONE. In the meantime, I will close this. This doesnt block v1 though. |
|
Do NOT delete the branch. |
No description provided.