fix(mongo,postgres): create/upsert autoInc field with primary set#77
Draft
Hieuzest wants to merge 2 commits intocordiverse:mainfrom
Draft
fix(mongo,postgres): create/upsert autoInc field with primary set#77Hieuzest wants to merge 2 commits intocordiverse:mainfrom
Hieuzest wants to merge 2 commits intocordiverse:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 36 36
Lines 7964 7988 +24
Branches 1997 2037 +40
=======================================
+ Hits 7832 7856 +24
Misses 132 132 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider the following snippets with autoInc enabled:
Currently in mongo driver,
create({ id: 1})will not update autoInc field, thus the secondcreate({ num: 1 })will get the sameid=1, causing duplicate primary error.PostgreSQL's serial type acts exactly our mongo's way. It only update itself when triggering default. The PR gives a workaround but i have no idea whether there exists better solution.
Unit tests are missing in the PR because there are not proper file to write them. (current update.ts will not run into problem cuz the autoInc is already high enough in that case) We should write them in model.ts later the other PR is merged.