Skip to content

Update SERDE in WebAuthnService #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
incorbador merged 1 commit into from
Oct 8, 2025
Merged

Update SERDE in WebAuthnService #546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions packages/web-core/src/services/WebAuthnService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
/// <reference types="user-agent-data-types" /> <- add this line
import type { ClientCapabilities } from '@corbado/types';
import { create, get } from '@corbado/webauthn-json';
import { createResponseToJSON, getResponseToJSON } from '@corbado/webauthn-json/extended';
import FingerprintJS from '@fingerprintjs/fingerprintjs';
import { detectIncognito } from 'detectincognitojs';
import log from 'loglevel';
Expand Down Expand Up @@ -73,10 +74,17 @@ export class WebAuthnService {
} as never)) as PublicKeyCredential;
}

return {
response: JSON.stringify(credential.toJSON()),
message: '',
};
try {
return {
response: JSON.stringify(credential.toJSON()),
message: '',
};
} catch (e) {
return {
response: JSON.stringify(createResponseToJSON(credential)),
message: 'toJSON() not available on PublicKeyCredential',
};
}
}

async login(
Expand Down Expand Up @@ -125,10 +133,17 @@ export class WebAuthnService {
signal: abortController.signal,
})) as PublicKeyCredential;

return {
response: JSON.stringify(credential.toJSON()),
message: '',
};
try {
return {
response: JSON.stringify(credential.toJSON()),
message: '',
};
} catch (e) {
return {
response: JSON.stringify(getResponseToJSON(credential)),
message: 'toJSON() not available on PublicKeyCredential',
};
}
}

async getClientInformation(maybeClientHandle: ClientStateEntry<string> | undefined): Promise<ClientInformation> {
Expand Down
Loading