Merged
Conversation
added 7 commits
June 10, 2025 14:40
incorbador
reviewed
Jun 24, 2025
| - testType: connect | ||
| configFile: playwright.config.connect.ts | ||
| env: | ||
| PLAYWRIGHT_NUM_CORES: 4 |
Contributor
There was a problem hiding this comment.
do we have to list all ENVs here explicitly?
Author
There was a problem hiding this comment.
An alternative is to save all env vars into one github secret, and then to print it in its entirety into an env file in the github runner before running the tests. This way we wouldn't have to modify the workflow file whenever we add or remove a test env var, but I think our current approach is better because it is easier to modify the value of each individual environment variable in github secrets
incorbador
reviewed
Jun 24, 2025
incorbador
reviewed
Jun 24, 2025
added 7 commits
June 24, 2025 11:22
…e every test group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.