Skip to content

remove oauth consent screen from google social login tests #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aehnh merged 3 commits into from
Mar 18, 2025
Merged

remove oauth consent screen from google social login tests #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f148f44
skip social login test
Mar 12, 2025
b64d478
Merge branch 'develop' into social
Mar 18, 2025
2cc686f
remove oauth consent screens from google social login
Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions packages/tests-e2e/src/complete/utils/externalauth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,20 +95,20 @@ export const socialLogin = async (page: Page, gmail: string, password: string, s
await gmailPage.close();

await page.getByRole('button', { name: 'Continue with Google' }).click();
await expect(page.getByRole('heading')).toHaveText('Choose an account');

await page.getByRole('button', { name: 'Corbado Systemtest' }).click();
await expect(page.getByRole('heading')).toHaveText('corbado-staging.io wants to access your Google Account');

await page.getByRole('button', { name: 'Allow' }).click();
// await expect(page.getByRole('heading')).toHaveText('Choose an account');
//
// await page.getByRole('button', { name: 'Corbado Systemtest' }).click();
// await expect(page.getByRole('heading')).toHaveText('corbado-staging.io wants to access your Google Account');
//
// await page.getByRole('button', { name: 'Allow' }).click();
};

export const repeatSocialLogin = async (page: Page) => {
await page.getByRole('button', { name: 'Continue with Google' }).click();
await expect(page.getByRole('heading')).toHaveText('Choose an account');

await page.getByRole('button', { name: 'Corbado Systemtest' }).click();
await expect(page.getByRole('heading')).toHaveText('corbado-staging.io wants to access your Google Account');

await page.getByRole('button', { name: 'Allow' }).click();
// await expect(page.getByRole('heading')).toHaveText('Choose an account');
//
// await page.getByRole('button', { name: 'Corbado Systemtest' }).click();
// await expect(page.getByRole('heading')).toHaveText('corbado-staging.io wants to access your Google Account');
//
// await page.getByRole('button', { name: 'Allow' }).click();
};
2 changes: 1 addition & 1 deletion packages/tests-e2e/src/connect/fixtures/BaseTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import { test as base } from '@playwright/test';

import { BaseModel } from '../models/BaseModel';
import { CDPSessionManager } from '../utils/CDPSessionManager';
import { VirtualAuthenticator } from '../utils/VirtualAuthenticator';
import { NetworkRequestBlocker } from '../utils/NetworkRequestBlocker';
import { VirtualAuthenticator } from '../utils/VirtualAuthenticator';

export const test = base.extend<{ model: BaseModel }>({
model: async ({ page }, use) => {
Expand Down
Loading