Adds config option to disable auto focus of fields #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaskratzel
force-pushed
the
496-make-auto-focus-on-input-fields-configurable
branch
from
06438b8 to
1b3bf86
Compare
lukaskratzel
force-pushed
the
496-make-auto-focus-on-input-fields-configurable
branch
from
d59f36b to
5c76ecd
Compare
This reverts commit 5c76ecd.
incorbador
reviewed
Jan 21, 2025
packages/types/src/component.ts
Outdated
| onLoggedIn: () => void; | ||
| handleNavigationEvents?: boolean; | ||
| initialBlock?: 'signup-init' | 'login-init'; | ||
| autoFocus?: boolean; |
Contributor
There was a problem hiding this comment.
autoFocus => initialAutoFocus? (the name would then indicate that the setting only applies for "initial" blocks => i.e. login-init and signup-init)
incorbador
approved these changes
Jan 21, 2025
lukaskratzel
force-pushed
the
496-make-auto-focus-on-input-fields-configurable
branch
2 times, most recently
from
2a22b38 to
1d22e0f
Compare
lukaskratzel
force-pushed
the
496-make-auto-focus-on-input-fields-configurable
branch
from
1d22e0f to
52132af
Compare
lukaskratzel
deleted the
496-make-auto-focus-on-input-fields-configurable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add config option
autoFocustoCorbadoAuth,SignUpandLogin. It is optional and set totrueby default so previous behavior stays consistent. Iffalse, it will prevent autoFocus of input fields in both signup-init and login-init blocks, so only "entry" blocks are affected.