Open
Conversation
eitoball
added a commit
to misoca/rrrspec
that referenced
this pull request
Aug 22, 2018
hidakatsuya
added a commit
to misoca/rrrspec
that referenced
this pull request
Aug 27, 2018
This reverts commit e4c2c0a.
hidakatsuya
added a commit
to misoca/rrrspec
that referenced
this pull request
Aug 27, 2018
Revert "Revert "merge cookpad#75""
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
rrrspec reports false results when
errors_outside_of_exampleshas positive counts; for example,include_contextis used but no context in it.In this case, examples in other files are also skipped.
Local test result of 2567d87 is here.
Solution
c38c379 fix that case by checking
errors_outside_of_examples_countin report summary.Local test result of the commit is here.