Open
Conversation
jrluis
commented
Aug 29, 2016
jrluis
commented
- This avoid unnecessary notifications of the master
* This avoid unnecessary notifications of the master
| worker_log = WorkerLog.create(@worker, taskset) | ||
| logger = TimedLogger.new(worker_log) | ||
|
|
||
| break if taskset.status == 'running' |
Contributor
There was a problem hiding this comment.
This check has done in l.196.
Author
There was a problem hiding this comment.
Can't use check.call because it would return from the work method.
The fix relies on not notifying the master if the worker has tasksets in the queue. After returning from work method a notification to master is sent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.