Fix email validation regex to require 2+ character TLDs#67
Open
bellisabell wants to merge 1 commit intomainfrom
Open
Fix email validation regex to require 2+ character TLDs#67bellisabell wants to merge 1 commit intomainfrom
bellisabell wants to merge 1 commit intomainfrom
Conversation
The regex pattern [a-z]+ allowed single-letter TLDs which are invalid.
Changed to [a-z]{2,} to require at least 2 characters.
Closes #31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the email validation regex that was allowing single-letter TLDs (e.g.,
user@example.a).Changes
Changed the TLD portion of
VALID_EMAIL_REGEXfrom[a-z]+to[a-z]{2,}to require at least 2 characters, which matches valid TLD requirements.Testing
Emails like
user@example.awill now be rejected, while valid emails likeuser@example.comoruser@example.cocontinue to work.Closes #31