Fix nil crash on unsubscribe page with invalid token#66
Open
bellisabell wants to merge 1 commit intomainfrom
Open
Fix nil crash on unsubscribe page with invalid token#66bellisabell wants to merge 1 commit intomainfrom
bellisabell wants to merge 1 commit intomainfrom
Conversation
Add require_email_message before_action to check if the unsubscribe token is valid. When an invalid token is provided, render a friendly error page instead of crashing with a nil reference. Closes #27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a user visits the unsubscribe page with an invalid or missing token, the app crashes with a nil reference error because
set_email_messageusesfind_bywhich returns nil, and the view tries to access@email_message.subscription.Solution
require_email_messagebefore_action that checks if@email_messageis presentinvalid_token.html.erbview with helpful message explaining the link may have expiredTesting
Visit
/unsubscribe?token=invalid- should now show friendly error page instead of crashing.Closes #27